Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

report: fix build warning in node_report.cc #26265

Merged
merged 1 commit into from
Feb 28, 2019
Merged

report: fix build warning in node_report.cc #26265

merged 1 commit into from
Feb 28, 2019

Conversation

richardlau
Copy link
Member

@richardlau richardlau commented Feb 22, 2019 •
edited
Loading

Fixes the following build warning:

CXX(target) /home/travis/build/nodejs/node/out/Release/obj.target/node_lib/src/node_report.o
../src/node_report.cc: In function ‘std::string report::TriggerNodeReport(v8::Isolate*, node::Environment*, const char*, const char*, std::string, v8::Local<v8::String>)’:
../src/node_report.cc:184:76: warning: ‘outstream’ may be used uninitialized in this function [-Wmaybe-uninitialized]
       isolate, env, message, location, filename, out, stackstr, &tm_struct);
                                                                            ^
../src/node_report.cc:149:17: note: ‘outstream’ was declared here
   std::ostream* outstream;
                 ^
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@richardlau sadly an error occured when I tried to trigger a build :(

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Feb 22, 2019
@richardlau richardlau added the report Issues and PRs related to process.report. label Feb 22, 2019
cjihrig
cjihrig approved these changes Feb 22, 2019
View reviewed changes
src/node_report.cc Outdated Show resolved Hide resolved
@richardlau
Copy link
Member Author

CI will need to wait until the lockdown ends.

@Trott
Copy link
Member

Trott commented Feb 22, 2019

CI looks quiescent right now, so here you go: https://ci.nodejs.org/job/node-test-pull-request/20971/

Not sure if the GitHub widget will still report results or if someone with access will have to let you know if it passed or not.

@richardlau
Copy link
Member Author

CI looks quiescent right now, so here you go: https://ci.nodejs.org/job/node-test-pull-request/20971/

Not sure if the GitHub widget will still report results or if someone with access will have to let you know if it passed or not.

The status is being posted, so the widget is showing results. node-test-commit-windows-fanned failed -- if anyone has access could comment on whether the failure looks related to this PR (in which case please post the relevant log) or some flake/infra issue.

FTR I'm in no particular rush to land this.

@Trott
Copy link
Member

Trott commented Feb 22, 2019 •
edited
Loading

@richardlau The Windows failure is a pervasive infra-related thing. If you're in no rush, once it's fixed, we can do a quick Resume Build.

@Trott
Copy link
Member

Trott commented Feb 22, 2019

I think @refack fixed stuff. 🎉 Here's a Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/20972/

@richardlau
Copy link
Member Author

Rebased based on irc chat suggestions that the Windows issue is #25593 and that recent commits to master may have mitigated it.

@Trott
Copy link
Member

Trott commented Feb 23, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/20974/

I don't think it's been fixed yet, but I'll be happy to be wrong....

@cjihrig cjihrig mentioned this pull request Feb 24, 2019
Closed
4 tasks
mhdawson
mhdawson approved these changes Feb 26, 2019
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Trott
Copy link
Member

Trott commented Feb 26, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/21008/

@richardlau
Copy link
Member Author

richardlau commented Feb 28, 2019 •
edited
Loading

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/21031/ (✔️)

@richardlau richardlau added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 28, 2019
@richardlau
report: fix build warning in node_report.cc
4a10ce6 
Fixes `maybe-uninitialized` build warning in `src/node_report.cc`.

PR-URL: nodejs#26265
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@richardlau richardlau merged commit 4a10ce6 into nodejs:master Feb 28, 2019
@richardlau
Copy link
Member Author

Landed in 4a10ce6.

addaleax pushed a commit that referenced this pull request Mar 1, 2019
@richardlau @addaleax
report: fix build warning in node_report.cc
2fe9886 
Fixes `maybe-uninitialized` build warning in `src/node_report.cc`.

PR-URL: #26265
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@BridgeAR BridgeAR mentioned this pull request Mar 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@mhdawson mhdawson mhdawson approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. report Issues and PRs related to process.report.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@richardlau @nodejs-github-bot @Trott @jasnell @addaleax @cjihrig @mhdawson